-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge 1.0 branch into master #327
Conversation
Move Batch Table hierarchy to an extension
Upgrade tilesets to version 1.0
List looks good. Maybe a final copy edit if @slchow has the time, but I don't think it's necessary in order to merge this. |
Only other thing I can think of is if we want to park current master in a branch because it has the start of some additional tile formats like VectorData, unless we want to carry over those changes here. |
Disregard my above comment, I see the |
If not a branch, maybe a tag for the current master so we can reference it later as needed. |
I pushed a |
I could copyedit, but it would realistically be the end of next week at least before I could get to it. @lilleyse Do you want me to look it over? |
I think it's fine to merge without a copyedit. |
Fixed a few typos and published a new PDF. I think this should be ready to go. |
I quickly glanced at the pdf - just some small things to address:
Would this note need to change? Should it instead refer to the This also reminds me that the current In the introduction section, and in other areas, some of the tile formats are written in a plural form, but they should be singular.
|
Otherwise looks great! |
Thanks @lilleyse! Made the fixes in the PDF, and now reference the tag instead of the branch. I don't see any |
Oh I was mixing up the tags... But yeah, keep the It also looks like some files got added accidentally to the last commit. |
Sounds good 👍 Whoops, removed the extra files, and updated. |
In addition to creating the tag, could you also fix the now-broken spec links mentioned in the PR description? That looks like everything. Thanks @ggetz! |
The updates here have already been reviewed, mostly in #308. The
1.0
changes should be ready to merge intomaster
now.Right after merging:
3d-tiles/tree/master/
and3d-tiles/tree/1.0/
and these projects had links:@pjcozzi @ggetz is there anything left to add here?