Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds 3DTILES_binary_buffers extension #428

Closed
wants to merge 1 commit into from

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Sep 22, 2020

Supersedes #415 which was not versioned.

Direct Link Draft Version Changes
3DTILES_binary_buffers 0.0.0 Initial draft

This extension enables 3D Tiles to reference binary buffers. Useful as a building block for other extensions.

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 22, 2020

@lilleyse LMK when this is ready for me to review. Meanwhile, are you sure this should target master? Shouldn't this be queued up in a 3D Tiles Next branch so it can be fully vetted?

@lilleyse lilleyse force-pushed the 3DTILES_binary_buffers branch 2 times, most recently from d3d95ef to e499626 Compare September 22, 2020 01:58
@lilleyse lilleyse force-pushed the 3DTILES_binary_buffers branch from e499626 to 069a307 Compare September 22, 2020 02:51
@lilleyse
Copy link
Contributor Author

Meanwhile, are you sure this should target master? Shouldn't this be queued up in a 3D Tiles Next branch so it can be fully vetted?

Ah yes, I'll need to re-target most of the open PRs.

@lilleyse lilleyse changed the base branch from master to 3d-tiles-next October 9, 2020 19:06
@lilleyse lilleyse marked this pull request as draft October 25, 2020 18:31
@lilleyse
Copy link
Contributor Author

No longer needed for tile metadata.

@ptrgags is there anything here that can make its way into #444?

@lilleyse lilleyse closed this Jan 20, 2021
@lilleyse lilleyse deleted the 3DTILES_binary_buffers branch October 19, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants