This PR adds support for 3D Tiles Next #58

sanjeetsuhag · 2021-07-09T12:10:50Z

3D Tiles Next is a set of capabilities for the future of 3D Tiles. Read the overview document for more details.

This PR adds support for the following extensions:

EXT_mesh_gpu_instancing
EXT_feature_metadata
3DTILES_content_gltf
3DTILES_implicit_tiling

This PR also adds support for the RMTexture and RMDescriptor datasets.

lilleyse · 2021-07-13T00:19:40Z

The feature table property elementCount can be removed. It has since been removed from EXT_feature_metadata.

lilleyse · 2021-07-13T00:21:12Z

GTModels have a _FEATURE_ID_0 attribute on each primitive but it's not linked to a feature table. I assume it can be removed because the instancing extension is what links to the feature table.

lilleyse · 2021-07-13T00:23:04Z

For San Diego - what is the GTModels/1_1/Gltf folder for? It has D500_S001_T001_AL015_000_coronado_bridge.glb but N32W118_D101_S001_T001.json doesn't seem to reference it.

lilleyse · 2021-07-13T00:23:48Z

HydrographyNetwork/N32W118_D204_S002_T005_LC6_U0_R0.glb doesn't pass the validator. (That's the only one I checked, but I assume something is wrong with vector datasets)

lilleyse · 2021-07-12T23:10:36Z

CDBTo3DTiles/src/CDBAttributes.h

+        descriptions["FSC"] = "This code, in conjunction with the FACC is used to distinguish and categorize features within a dataset.";
+        descriptions["HGT"] = "Distance measured from the lowest point of the base at ground (non-floating objects) or water level (floating objects downhill side/downstream side) to the tallest point of the feature above the surface. Recorded values are positive numbers. In the case of roads and railroads, HGT corresponds to the elevation of the road/railroad wrt terrain in its immediate vicinity.";
+        descriptions["MLOD"] = "The level of detail of the 3D model associated with the point feature. When used in conjunction with MODL, the MLOD attribute indicates the LOD where the corresponding MODL is found. In this case, the value of MLOD can never be larger than the LOD of the Vector Tile-LOD that contains it. When used in the context of Airport and Environmental Light Point features, the value of MLOD, if present, indicates that this light point also exist in a 3D model found at the specified LOD. In such case, the value of MLOD is not constrained and can indicate any LOD.";
+        descriptions["MODL"] = "	A string reference, the model name, which stands for the modeled geometry of a feature; in the case of buildings, this includes both its external shell and modeled interior. Usage Note: Needed for Point features, Road Figure Point features, Railroad Figure Point features, Pipeline Figure Point features and Hydrography Figure Point features that are modeled as OpenFlight or as RCS (Shape). MODL can also be used with Road Lineal features, Railroad Lineal features, Pipeline Lineal features and Hydrography Lineal and Areal features. Note that it is not permitted to specify a value for MODL simultaneously with a value for MMDC.";


Suggested change

descriptions["MODL"] = " A string reference, the model name, which stands for the modeled geometry of a feature; in the case of buildings, this includes both its external shell and modeled interior. Usage Note: Needed for Point features, Road Figure Point features, Railroad Figure Point features, Pipeline Figure Point features and Hydrography Figure Point features that are modeled as OpenFlight or as RCS (Shape). MODL can also be used with Road Lineal features, Railroad Lineal features, Pipeline Lineal features and Hydrography Lineal and Areal features. Note that it is not permitted to specify a value for MODL simultaneously with a value for MMDC.";

descriptions["MODL"] = "A string reference, the model name, which stands for the modeled geometry of a feature; in the case of buildings, this includes both its external shell and modeled interior. Usage Note: Needed for Point features, Road Figure Point features, Railroad Figure Point features, Pipeline Figure Point features and Hydrography Figure Point features that are modeled as OpenFlight or as RCS (Shape). MODL can also be used with Road Lineal features, Railroad Lineal features, Pipeline Lineal features and Hydrography Lineal and Areal features. Note that it is not permitted to specify a value for MODL simultaneously with a value for MMDC.";

lilleyse · 2021-07-13T00:02:07Z

CLI/main.cpp

+    options.add_options("hidden")
+      ("3d-tiles-next",
+        "Experimental convert to 3DTiles with 3DTILES_content_gltf, 3DTILES_implicit_tiling, and EXT_feature_metadata extensions.",
+        cxxopts::value<bool>()->default_value("false"))
+      ("external-schema",
+        "Use external schema file for Feature Metadata.",
+        cxxopts::value<bool>()->default_value("false"))
+      ("subtree-levels",
+        "The number of levels in each subtree for implicit tiling.",
+        cxxopts::value<int>()->default_value("7"));


These don't need to be hidden options.

lilleyse · 2021-07-13T00:03:20Z

CLI/main.cpp

+      ("external-schema",
+        "Use external schema file for Feature Metadata.",
+        cxxopts::value<bool>()->default_value("false"))


I think schemas should be external by default to help cut down on glb sizes. Maybe then the option would be renamed to --embedded-schema

lilleyse · 2021-07-13T00:27:41Z

The UI in the linked sandcastle does something weird when the info button is clicked:

lilleyse · 2021-07-13T00:28:55Z

@sanjeetsuhag I forget, are we able to post a sandcastle demo for Yemen? It would be great to show off the feature id textures

lilleyse · 2021-07-13T00:30:39Z

@sanjeetsuhag @ErixenCruz that's my first pass over the CLI, README, and inspecting the tileset output. I'll probably do a quick code pass later. So far seems pretty good!

ErixenCruz · 2021-07-13T13:34:07Z

For #39 I think it would not be too much work. We already have that branch that is mentioned in the issue that has most of the changes needed to calculate the tighter bounding region. For implicit, only the non positive levels would be affected.

ErixenCruz · 2021-07-13T13:39:45Z

Why is content availability stored in a separate binary file instead of embedded in the subtree?

I believe originally for multicontent, we were going to need per-content availability, and we thought it made more sense to store availability binaries within their respective content folder instead of smashing them all on the end of the subtree file. Multicontent was abandoned, but that decision was not revisited

sanjeetsuhag · 2021-07-16T15:53:03Z

@sanjeetsuhag I forget, are we able to post a sandcastle demo for Yemen? It would be great to show off the feature id textures

Yes. the Sandcastle can be found here.

sanjeetsuhag · 2021-07-29T14:42:08Z

An optimization for creating bounding volumes for instanced models would be to add the min and max of the TRANSLATION values to the accessor.

lilleyse · 2021-08-31T00:18:49Z

I pushed a commit that fixes the 3D Tiles Next links. See CesiumGS/3d-tiles#478

lilleyse · 2021-09-27T21:50:45Z

@sanjeetsuhag is there any top-level metadata (provenance information like author, date, etc) that should get carried over into tileset metadata? And more generally is there any other CDB metadata that's not getting carried through into the tileset?

CC @bradyjmoore

sanjeetsuhag · 2021-09-27T22:03:46Z

@lilleyse From what I recall, the problem here is that the CDB datasets we have kinda follow rules of their own in terms of what they put in the top level Metadata folders. I remember the LA CDB had a completely different set of namespaces in its Metadata.XML compared to the San Diego one. That being said, I don't think we've looked at the CDB spec either about what the typical way of doing this is.

update glbLength and jsonChunkLength before references are invalidated by glbStr.insert

sanjeetsuhag · 2021-11-08T22:19:50Z

Before this is merged, we should implement support for propagating feature ID textures to higher LODs where the RMTexture dataset does not extend, but the Imagery does.

…tiles into 3d-tiles-next

Fixed glb padding issue

Fix padding in combineGltfs

ErixenCruz and others added 30 commits January 25, 2021 16:01

Add 3d tiles next option

fd55197

Add libmorton as external repo

ef4a87e

Hidden options fix

f140fe5

Libmorton include dir

2aaf5b3

Libmorton include directory from external repo

01f0bf0

Availability buffer for elevation

3ab941d

Fix seg fault when more than one geocell

4709ed6

elevation subtree json

0d0aba3

Make converter class and add unit test

b10f7f7

Availability test

15e31d1

Sanity building check.

ed47fa1

add FileUtil for writing subtree binary files

545fdc2

Child availability, combine into subtree binary

0578271

Fix availability test

230838b

Adds function to write EXT_feature_metadata

4f6f7c4

Adds _FEATURE_ID attribute to primitive

6c5f6f4

Adds individual buffers/bufferViews to integer properties

c4efccf

Adds codepath to add feature metadata for 3D Tiles Next

8b80c2b

Create implicit tileset json and make b3dms

26b7849

Move content to under root tile

68a10f7

Fix subtree file names

28e65e0

Adds alternative method for adding extension

82a7ffa

Fix buffer length in subtree json

a208003

Add buffers object to subtree json

9dfb3f5

Fix buffers in subtree json

6eb659e

Byte length smaller if constant avail

fb37725

bytelength accounts for constant

926c79c

buffer byte length fix

7ba081b

Temporarily fixes extension writing

5ce0783

Removes EXT_feature_metadata from extensionsRequired

4e2ee4c

lilleyse reviewed Jul 13, 2021

View reviewed changes

Add second demo

9bae38d

Fix broken 3D Tiles Next links

c943875

nithinp7 added 3 commits November 1, 2021 15:35

Fixed padding not properly updating glb and json chunk byte lengths

6b64f5c

json chunk length should be reference

3ed897f

fix possible invalidated references

c7b1c67

update glbLength and jsonChunkLength before references are invalidated by glbStr.insert

lilleyse mentioned this pull request Nov 3, 2021

3D Tiles Next roadmap CesiumGS/cesium-native#386

Closed

10 tasks

Sanjeet Suhag added 2 commits November 10, 2021 14:57

Updated Catch2 to v2.13.6

df2729f

Merge branch '3d-tiles-next' of https://github.com/CesiumGS/cdb-to-3d…

4fbb27d

…tiles into 3d-tiles-next

nithinp7 mentioned this pull request Dec 2, 2021

EXT_feature_metadata buffers are not 8-byte aligned #64

Open

lilleyse added 5 commits May 6, 2022 18:06

Add ThirdParty.json

9a7ee2c

Fix g++11 build

6647a8f

Merge pull request #62 from CesiumGS/glb-padding-fix

c2caf2a

Fixed glb padding issue

Fix padding when combining different glTFs

1c720e8

Merge pull request #68 from CesiumGS/fix-padding

134f80a

Fix padding in combineGltfs

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

This PR adds support for 3D Tiles Next #58

This PR adds support for 3D Tiles Next #58

sanjeetsuhag commented Jul 9, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse Jul 12, 2021

lilleyse Jul 13, 2021

lilleyse Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

ErixenCruz commented Jul 13, 2021

ErixenCruz commented Jul 13, 2021

sanjeetsuhag commented Jul 16, 2021

sanjeetsuhag commented Jul 29, 2021

lilleyse commented Aug 31, 2021

lilleyse commented Sep 27, 2021

sanjeetsuhag commented Sep 27, 2021

sanjeetsuhag commented Nov 8, 2021

This PR adds support for 3D Tiles Next #58

Are you sure you want to change the base?

This PR adds support for 3D Tiles Next #58

Conversation

sanjeetsuhag commented Jul 9, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse Jul 12, 2021

Choose a reason for hiding this comment

lilleyse Jul 13, 2021

Choose a reason for hiding this comment

lilleyse Jul 13, 2021

Choose a reason for hiding this comment

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

lilleyse commented Jul 13, 2021

ErixenCruz commented Jul 13, 2021

ErixenCruz commented Jul 13, 2021

sanjeetsuhag commented Jul 16, 2021

sanjeetsuhag commented Jul 29, 2021

lilleyse commented Aug 31, 2021

lilleyse commented Sep 27, 2021

sanjeetsuhag commented Sep 27, 2021

sanjeetsuhag commented Nov 8, 2021