Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the glTF importer would ignore tangents in the model. This PR ensure that tangents in the vertex stream are properly imported and transferred to the relevant vertex buffer.
(This depends on #611 so merge that first.)
Author checklist
CHANGES.md
with a short summary of my change (for user-facing changes).Testing plan
Load a glTF that includes tangents, such as the glTF Normal Tangent Mirror Test.
In Unity's Render Debugger, activate the Tangent material override and verify that tangents are included.
By default, Unity provides
(1,0,0)
for tangents if they are missing. The tangent vertex attribute override should show something other than(1,0,0)
.