Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TUTORIAL.md #59

Merged
merged 3 commits into from
May 2, 2024
Merged

Update TUTORIAL.md #59

merged 3 commits into from
May 2, 2024

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented Apr 26, 2024

Updated out-of-date code which was included in the tutorial.

I also removed the ion access token, as we want to encourage users to generate their own instead.

Updated out-of-date code which was included in the tutorial. 

I also removed the ion access token, as we want to encourage users to generate their own instead.
@ggetz ggetz requested a review from jjspace April 26, 2024 18:27
Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think when I did the refresh of this repo there was some discussion of completely removing this tutorial page in it's entirety for being out of date and a bit too specific and hard to maintain. However if we want to keep it these changes look fine.

TUTORIAL.md Show resolved Hide resolved
TUTORIAL.md Show resolved Hide resolved
@ggetz
Copy link
Contributor Author

ggetz commented May 1, 2024

I think when I did the refresh of this repo there was some discussion of completely removing this tutorial page in it's entirety for being out of date and a bit too specific and hard to maintain. However if we want to keep it these changes look fine.

If this continues to be a lift in the future to keep up-to-date, we'll delete. Since this is an API update that should have happened before, let's move forward with it for now.

@ggetz
Copy link
Contributor Author

ggetz commented May 1, 2024

Thanks @jjspace! This should be ready now.

Copy link
Contributor

@jjspace jjspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@jjspace jjspace merged commit 23638ff into main May 2, 2024
5 checks passed
@jjspace jjspace deleted the ggetz-patch-1 branch May 2, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants