Skip to content

Commit

Permalink
Merge pull request #12263 from CesiumGS/release-tests
Browse files Browse the repository at this point in the history
Don't rebuild during the release process
  • Loading branch information
ggetz authored Oct 28, 2024
2 parents bb40a85 + 1279840 commit e168f90
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion Documentation/Contributors/ReleaseGuide/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ There is no release manager; instead, our community shares the responsibility. A
13. Run `npm install`.
14. Make sure `ThirdParty.json` is up to date by running `npm run build-third-party`. If there are any changes, verify and commit them.
15. Create the release zip `npm run make-zip`.
16. Run tests against the release `npm run test -- --failTaskOnError --release`. Test **in all browsers** with the `--browsers` flag (i.e. `--browsers Firefox,Chrome`). Alternatively, test with the browser Spec Runner by starting a local server (`npm start`) and browsing to http://localhost:8080/Specs/SpecRunner.html?built=true&release=true.
16. Run tests against the release `npm run test -- --failTaskOnError --release`. Test **in all browsers** with the `--browsers` flag (i.e. `--browsers Firefox,Chrome`). Alternatively, test with the browser Spec Runner by starting a local server (`npm start -- --production`) and browsing to http://localhost:8080/Specs/SpecRunner.html?built=true&release=true.
17. Run end to end tests against the release with `npm run test-e2e-release`, or multiple browsers with `npm run test-e2e-release-all`.
18. Unpack the release zip to the directory of your choice and start the server by running `npm install` and then `npm start`
19. Browse to http://localhost:8080 and confirm that the home page loads as expected and all links work.
Expand Down
2 changes: 1 addition & 1 deletion gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -1006,7 +1006,7 @@ export async function test() {
workspace = workspace.replaceAll(`@${scope}/`, ``);
}

if (!isProduction) {
if (!isProduction && !release) {
console.log("Building specs...");
await buildCesium({
iife: true,
Expand Down

0 comments on commit e168f90

Please sign in to comment.