Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse input breaks with geocoder + home button #1336

Closed
kring opened this issue Dec 9, 2013 · 2 comments
Closed

Mouse input breaks with geocoder + home button #1336

kring opened this issue Dec 9, 2013 · 2 comments

Comments

@kring
Copy link
Member

kring commented Dec 9, 2013

  1. Type a location into the geocoder widget and press enter.
  2. After the fly animation starts but before it finishes, press the home button.

The original fly to the geocoded location is aborted, and you fly to the home view instead. But then mouse input doesn't work anymore. There's no exception or other error in the console. You can type a new location into the geocoder and fly there; it's only mouse input that doesn't work.

@mramato
Copy link
Contributor

mramato commented Dec 11, 2013

There's also a problem if you click the home button and then click it a second time while it's in-flight (no Geocoder required). It's probably the same bug in both cases (I thought we had an issue already, but I couldn't find it.)

Unfortunately, I think this is a problem regarding how we handle animations at a low-level (there are similar bugs in scene transitions). We really need to work the entire animation API.

@pklinef
Copy link

pklinef commented Dec 23, 2013

I am having a similar issue with adding animations and then clicking the home button before they finish. It looks like disableInput in CameraFlightPath saves the current state of what mouse input is enabled or disabled. If a new CameraFlightPath is created while another CameraFlightPath is in progress, the new one will save and restore the disabled input state.

One workaround is to remove all current animations so the restoreInput callback is called before creating new CameraFlightPaths. This is what is done in the Camera sandbox example on line 142.

@emackey emackey closed this as completed in 41f52e7 Jan 8, 2014
mramato added a commit that referenced this issue Jan 8, 2014
Fix #1336 by adding a master kill switch for inputs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants