-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures in master #1402
Comments
Running the tests individual seems to work, only when running the whole suite do you get any failures. Something weird is definitely going on here. |
There are leftover animations in Tween. Scene never destroys its AnimationCollection. |
Similarly, ScreenSpaceCameraController should destroy its AnimationCollection as well. |
Actually, upon further inspection, due to the disastrous state that AnimationCollection is in, calling removeAll on a single AnimationCollection instance will remove all animations globally, so maybe that's not the best approach. Perhaps instead GeocoderViewModel should keep track of its own animation and remove it from the collection when destroyed. |
CC #1188 |
Tell me if I'm doing something wrong, but I cleared cache and clean built master.
24 failures in Chrome (Canary) and 30 in Firefox (stable).
Chrome:

Firefox:

The text was updated successfully, but these errors were encountered: