Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures in master #1402

Closed
pjcozzi opened this issue Jan 24, 2014 · 5 comments
Closed

Test failures in master #1402

pjcozzi opened this issue Jan 24, 2014 · 5 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 24, 2014

Tell me if I'm doing something wrong, but I cleared cache and clean built master.

24 failures in Chrome (Canary) and 30 in Firefox (stable).

Chrome:
image

Firefox:
image

@mramato
Copy link
Contributor

mramato commented Jan 24, 2014

Running the tests individual seems to work, only when running the whole suite do you get any failures. Something weird is definitely going on here.

@shunter
Copy link
Contributor

shunter commented Jan 24, 2014

There are leftover animations in Tween. Scene never destroys its AnimationCollection.

@shunter
Copy link
Contributor

shunter commented Jan 24, 2014

Similarly, ScreenSpaceCameraController should destroy its AnimationCollection as well.

@shunter
Copy link
Contributor

shunter commented Jan 24, 2014

Actually, upon further inspection, due to the disastrous state that AnimationCollection is in, calling removeAll on a single AnimationCollection instance will remove all animations globally, so maybe that's not the best approach. Perhaps instead GeocoderViewModel should keep track of its own animation and remove it from the collection when destroyed.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 24, 2014

CC #1188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants