Fix failing specs by properly isolating and cleaning up animations. #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each AnimationCollection instance now manages its own list of animations. Previously all instances would share global state. Also upgrade Tween to latest version.
|
Fixes #1402. |
|
This fixes the issue. One side-affect is that it changes the other animation related bugs in subtle ways. For example #1401 still happens, but instead of resetting back the the original location, the Geocoder flight is just ignored (unless the inertial finishes just in time, then it kicks it). However, I imagine that's a larger problem to tackle so I'll merge this now. |
mramato
added a commit
that referenced
this pull request
Jan 24, 2014
Fix failing specs by properly isolating and cleaning up animations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each AnimationCollection instance now manages its own list of animations. Previously all instances would share global state. Also upgrade Tween to latest version.