Concurrent morphs cause crash

[mramato]

Easy to reproduce with two widgets examples

1. Hit the 2D Map button on the top example
2. While the top widget is morphing, hit the 2D map button on the bottom example
3. When the top morph finishes, the example will crash.

I'm pretty sure this is a bug that occurs in any situation where multiple morphs are going at once across different scenes.

[mramato]

I spent some time debugging this problem. The issue is that SceneTransitioner adds and removes tweens inside the callback of other tweens. This is a big no-no because we end up modifying an array that is currently being iterated inside of TWEEN.update. Given the number of other problems with SceneTransitioner (like #602), I'm going to leave this as-is until it either becomes a larger problem or we finally refactor SceneTransitioner into its final form.

[mramato]

Do to change in transitioner architecture in #725, this is no longer an issue.

[mramato]

I was wrong, this is still an issue.

[pjcozzi]

@mramato can you still reproduce this?

In Sandcastle:

HTML:

<style>
    @import url(../templates/bucket.css);
</style>
<div id="cesiumContainer" class="top"></div>
<div id="cesiumContainer2" class="bottom"></div>

JavaScript:

var viewer = new Cesium.Viewer('cesiumContainer');
viewer.sceneModePicker.viewModel.duration = 30000.0;
var viewer2 = new Cesium.Viewer('cesiumContainer2');
viewer2.sceneModePicker.viewModel.duration = 30000.0;

[mramato]

I think the original problem is gone; there's still a crash but it's not related to having two widgets, I'll write up a separate issue.