Fix morph crash. #379
Fix morph crash. #379
Conversation
|
Instead of |
|
@emackey Good idea. I changed the vector comparison to use an epsilon as well. Anything else? |
|
I was going to nag you for tests, but it looks like there are 0 Am I correct in that this has nothing to do with #377 |
|
You are correct. I know what the problem is for #377 and it is separate. |
| // If the camera and frustum are already in position for the switch to | ||
| // a perspective projection, nothing needs to be animated. | ||
| camera.position = endPos2D; | ||
| camera.frustum = frustumCV.clone(); |
There was a problem hiding this comment.
Why not frustumCV.clone(camera.frustum);? Which will re-use the existing instance.
There was a problem hiding this comment.
camera.frustum is an OrthographicFrustum. frustumCV is a PerspectiveFrustum.
There was a problem hiding this comment.
That makes sense. Merging.
Prevent an animation duration of 0ms. In Tween.js, the elapsed time is computed as
(time - startTime) / durationand clamped at one. This is fine for the most common case wheretime > startTimewhich gets divided by zero to equal infinity and clamped to one. In the case wheretime == startTime(which explains why it was so hard to reproduce), the elapsed time will beNaNand cause a crash.This fixes the original problem in #319.
#338 is unrelated.