Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More accurate rendering of models in 2D #5112

Closed
lilleyse opened this issue Mar 16, 2017 · 7 comments
Closed

More accurate rendering of models in 2D #5112

lilleyse opened this issue Mar 16, 2017 · 7 comments

Comments

@lilleyse
Copy link
Contributor

The larger the model, the less accurate it will be represented in 2D since it does not use the model's latitude in determining a stretching factor. Maybe just a scale will work, or maybe its harder than that since certain areas of the model vary by their latitude. @bagnell you probably have a better grasp of the details here.

I remember this being a known limitation when 2D model support was added. It's something that's worth more investigation considering many of our models will actually be large city sections.

From this forum post: https://groups.google.com/forum/#!topic/cesium-dev/jBmwFWHgVDo

3D:
3d

Columbus View:
auto generated inline image 1

@bagnell
Copy link
Contributor

bagnell commented Mar 17, 2017

Yes, this was a known limitation when 2D support was added for models. For large models, we would need to go through the positions and project them to 2D. The farther the positions from the origin in model coordinates, the more inaccurate it will be in 2D.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 18, 2017

Maybe with emulating double-precision in the vertex shader (and with transform-feedback in WebGL 2.0, #797) the re-projection could be done on the GPU; it is not affine so it can't be burned into the model material.

Otherwise, I think we would have to use extra memory to store 3D and 2D positions.

@jadelhamilton
Copy link

jadelhamilton commented Mar 18, 2017 via email

@lilleyse
Copy link
Contributor Author

Possibly affecting this photogrammetry tileset too, from https://groups.google.com/forum/#!topic/cesium-dev/KxpSBtfKetk.
crackin2d
However not noticeable for the AGI photogrammetry tileset.
agi

@lilleyse
Copy link
Contributor Author

This came up on the forum: https://groups.google.com/forum/#!topic/cesium-dev/nq5SymE_PPg

@lilleyse
Copy link
Contributor Author

@j9liu can this be closed now that #10384 is merged?

@j9liu
Copy link
Contributor

j9liu commented May 31, 2022

I'll close this, yes

@j9liu j9liu closed this as completed May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants