Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandcastle "back" button broken #6509

Closed
emackey opened this issue Apr 27, 2018 · 1 comment
Closed

Sandcastle "back" button broken #6509

emackey opened this issue Apr 27, 2018 · 1 comment

Comments

@emackey
Copy link
Contributor

emackey commented Apr 27, 2018

Visit any Sandcastle page: https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/

Click on one of the gallery icons below. Note the top URL bar updates, and the new gallery item is loaded into the editor.

Now, click the back button. The Top URL goes back to the previous Sandcastle Demo URL, but the editor does not respond to the change. It used to, not sure when. I could bisect this if that's really needed (but it would take longer than normal since Sandcastle itself is part of my normal bisection workflow).

@shunter
Copy link
Contributor

shunter commented Apr 27, 2018

Likely I broke this in #6342. I looked at it briefly and popstate is firing but the state is null. I see that there's code that calls replaceState with null. Probably at the time I was not aware the app was actually using state for anything.

shunter added a commit that referenced this issue Apr 27, 2018
We store information in history state objects about the loaded demo.

Navigating to new demos calls pushState, and a fresh load
stores the demo specified via URL using replaceState.

Fixes #6509
shunter added a commit that referenced this issue Apr 27, 2018
We store information in history state objects about the loaded demo.

Navigating to new demos calls pushState, and a fresh load
stores the demo specified via URL using replaceState.

Fixes #6509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants