Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glTF 2.0 models dark on Samsung S8 #6622

Closed
lilleyse opened this issue May 24, 2018 · 7 comments
Closed

glTF 2.0 models dark on Samsung S8 #6622

lilleyse opened this issue May 24, 2018 · 7 comments

Comments

@lilleyse
Copy link
Contributor

glTF 2.0 models are rendered dark on the Samsung S8. My first guess is this is a shader precision issue that causes the PBR shader to break. Does anyone have this phone or a similar Android phone? Try this link:

https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/gallery/Physically-Based%20Materials.html

Screenshots are from a PC (correct) and a Samsung S8. Both are at the same time.

pc
s8

Reported on the forum: https://groups.google.com/forum/#!topic/cesium-dev/qYjFtc3Ktg8

PS: reminder to also look at #6334

@shehzan10
Copy link
Member

Here are the screen shots from an S9. Tried to. Match the time on the darker one.
screenshot_20180523-230407_chrome

screenshot_20180523-230428_chrome

@alx696
Copy link

alx696 commented Dec 11, 2018

@lilleyse Same b3dm model:

Ubuntu Chrome 71:
PC

Samsung S8 Chrome 70:
Android

I have disable shadows: new Cesium.Cesium3DTileset({ shadows: Cesium.ShadowMode.DISABLED }). Looks very dark ! shadows option not work.

@likangning93
Copy link
Contributor

Hi @alx696, I realized that the Galaxy S8 can have one of two different chipsets with different GPUs, do you know if your unit is Qualcomm or Exynos?

We might also be able to figure this out if you post the output from visiting http://webglreport.com/ on your device.

@alx696
Copy link

alx696 commented Dec 11, 2018

@likangning93 Mode: SM-9500

  • CPU: Qualcomm Snapdragon 835 MSM8998 (10nm)
  • GPU: Qualcomm Adreno 540

https://www.phonemore.com/samsung-galaxy-s8-sm-g9500/specs/3233

I have made a simple model, But same problem. See #7403

@alx696
Copy link

alx696 commented Dec 11, 2018

@likangning93 WebGL Report:

a
b
c
d
e

@OmarShehata
Copy link
Contributor

This should be fixed with #7944, and will be out with CesiumJS 1.59 coming out next week.

@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/qYjFtc3Ktg8

If this issue affects any of these threads, please post a comment like the following:

The issue at #6622 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants