Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local resources broken in Electron #6671

Closed
mramato opened this issue Jun 8, 2018 · 2 comments
Closed

local resources broken in Electron #6671

mramato opened this issue Jun 8, 2018 · 2 comments

Comments

@mramato
Copy link
Contributor

mramato commented Jun 8, 2018

See the original thread here: https://groups.google.com/d/msg/cesium-dev/L-sUSJgpumE/7VD107UzBAAJ

Regression from 1.45 (works in 1.44), most likely related to #6454.

@mramato
Copy link
Contributor Author

mramato commented Jun 8, 2018

Adding && (!defined(process.versions) || !defined(process.versions.electron)) to isNodeJs fixes the initial error, but there appears to be might be some other issues we recently introduced as well

mramato added a commit that referenced this issue Jun 23, 2018
Our Node.js detection was imperfect and unnecessary, we should have been
checking for the existence of `XMLHttpRequest` instead.

Fixes #6671
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/d/msg/cesium-dev/L-sUSJgpumE/7VD107UzBAAJ

If this issue affects any of these threads, please post a comment like the following:

The issue at #6671 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants