Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

devicePixelRatio and particle system demo #8369

Closed
mramato opened this issue Nov 6, 2019 · 1 comment · Fixed by #8371
Closed

devicePixelRatio and particle system demo #8369

mramato opened this issue Nov 6, 2019 · 1 comment · Fixed by #8371

Comments

@mramato
Copy link
Contributor

mramato commented Nov 6, 2019

  1. Run http://localhost:8080/Apps/Sandcastle/index.html?src=Particle%20System%20Weather.html&label=All
  2. On a devicePixelRatio > 1 machine, the snowflakes are much bigger. You can see this in Chrome via the responsive debugger.

CC @lilleyse @IanLilleyT is this a particle-system wide issue, or specific to this demo? (I think it's the latter but want to confirm).

@IanLilleyT
Copy link
Contributor

It's specific to the demo. The fix was pretty straightforward: just had to remove drawing buffer width from the size. See PR: #8371

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants