Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Particle Weather System Demo at different resolution scales #8371

Merged
merged 1 commit into from
Nov 6, 2019

Conversation

IanLilleyT
Copy link
Contributor

@IanLilleyT IanLilleyT commented Nov 6, 2019

Fixes #8369

Using a harcoded size instead of basing it off of the drawingBuffer. So that means this is a problem with the demo and not with the particle system itself.

@IanLilleyT IanLilleyT requested a review from lilleyse November 6, 2019 15:23
@cesium-concierge
Copy link

Thanks for the pull request @IanLilleyT!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@lilleyse
Copy link
Contributor

lilleyse commented Nov 6, 2019

👍

@lilleyse lilleyse merged commit 2966395 into master Nov 6, 2019
@lilleyse lilleyse deleted the weatherDemoFix branch November 6, 2019 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

devicePixelRatio and particle system demo
3 participants