Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace third party libraries with npm modules #9473

Closed
25 of 29 tasks
ebogo1 opened this issue Apr 7, 2021 · 6 comments
Closed
25 of 29 tasks

Replace third party libraries with npm modules #9473

ebogo1 opened this issue Apr 7, 2021 · 6 comments

Comments

@ebogo1
Copy link
Contributor

ebogo1 commented Apr 7, 2021

This issue will serve as a task list for replacing third party modules with npm modules. Here is the task list (incomplete for now; I'll be updating this as we go).

@mramato
Copy link
Contributor

mramato commented Apr 8, 2021

cesiumWorkerBootstrapper.js also has an entire copy of RequireJS in it because we needed to be able to load modules in a worked. We'll have to investigate if there is an alternative solution or (worst case) generate this file as part of the build step.

@lilleyse
Copy link
Contributor

@ebogo1 https://www.npmjs.com/package/ktx-parse should be added after #9513 is merged

@lilleyse
Copy link
Contributor

Just checking, does this task list account for third party libraries in cesium/ThirdParty and cesium/Sandcastle/ThirdParty?

@ebogo1
Copy link
Contributor Author

ebogo1 commented Jul 28, 2021

By Cesium/ThirdParty/ do you mean codemirror-5.52.0, dojo-release-1.10.4, jasmine-2.20, and jslint-2.11.0? As for the ones in Sandcastle, I'm not sure what the plan is for those; I had a comment about it in the original post of #9688.

@lilleyse
Copy link
Contributor

lilleyse commented Aug 23, 2021

One more late breaking third party library to account for - meshopt. Added in #9694.

Source/ThirdParty/meshopt_decode.js

Here's the npm library that we should try using instead: https://www.npmjs.com/package/meshoptimizer

Edit: see if adding meshopt from npm fixes #9751

@ggetz
Copy link
Contributor

ggetz commented Mar 29, 2023

Closing, as the original scope of this issue has been covered. Knockout.js, workers, and Sandcastle dependencies will be a separate effort.

@ggetz ggetz closed this as completed Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Issue/PR closed
Development

No branches or pull requests

4 participants