Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ThirdPartyNpm files into ThirdParty #9705

Merged
merged 4 commits into from
Aug 1, 2021

Conversation

ebogo1
Copy link
Contributor

@ebogo1 ebogo1 commented Jul 31, 2021

Does what the title says, part of #9473.

The main changes are in the gulpfile and .gitignore, @mramato to make sure I did this right.

@cesium-concierge
Copy link

Thanks for the pull request @ebogo1!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@mramato
Copy link
Contributor

mramato commented Aug 1, 2021

At a high level glance, this looks fine.. we'll need to compare the full npm staging branch to main to be sure before merging the whole thing for release.

@lilleyse
Copy link
Contributor

lilleyse commented Aug 1, 2021

Merging into the staging branch where we'll do a final pass over everything

@lilleyse lilleyse merged commit f1da729 into npm-third-party-staging Aug 1, 2021
@lilleyse lilleyse deleted the save-in-ThirdParty branch August 1, 2021 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants