-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript fixes again #10292
TypeScript fixes again #10292
Conversation
Thanks for the pull request @thw0rted!
Reviewers, don't forget to make sure that:
|
Add changelog entry
I just noticed that #10265 was called out in the changelog -- turns out that two of the "fixes" I made to the return type info should have been correct and it was the code that was wrong. It might be worth looking at the function bodies for the other return-type changes I have in this PR to double check that there aren't other similar errors waiting to bite somebody. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document how to prettier-ignore in docs README
Back out SSEH setInputAction overload Globe#material can be undefined
Thanks @thw0rted! After the last commit, the |
Fixed a few tsd-jsdoc warnings
Thanks @thw0rted! Latest changes look good. Can you back out the |
Re the 5+ overloads in one file looks bad, but the previous case was just one, I think so that exportKML gave the correct return type based on the options with which it was called. That would be a lot less verbose/confusing with the new system. I guess in the worst case I can always dig up the old commit if we need it again, but it'd be nice to leave it in place as an option. Your call? |
I would say hold off on adding the guide and the tooling until we have a verified use case in the code. It may be the path we end up going down eventually, and we'll have the record of it in this PR. But until we have a use case in the code itself, maintaining the documentation and tooling is questionable. |
Awesome, thanks @thw0rted! Thanks for your patience throughout the process. |
This is an updated branch for #8903. I hate to lose the conversation from there but submitting these changes as a single commit allowed me to significantly reduce the number of files in the patchset -- a lot of them were only related to
when.js
Promises, and that's no longer relevant. Hopefully this makes it easier to review and merge.