-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sun Size #1046
Merged
Sun Size #1046
Changes from 25 commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d3ae6ca
Fix sun size.
bagnell 5adf0cb
Merge branch 'master' into sunSize
bagnell 4f8e0c8
Merge remote-tracking branch 'origin/master' into sunSize
emackey a068243
Add a sunburst.
emackey 95f2b13
Get rid of sin() and cos() from sun shader.
emackey 0969c55
Added get/setGlowFactor to address a feature request in #769.
emackey 5d4410f
Merge pull request #1081 from AnalyticalGraphicsInc/sunburst
bagnell f882120
Fix whitespace.
emackey 5301126
More whitespace.
emackey 6bfaa62
Use Object.defineProperty for glowFactor.
emackey 04fa8f6
Switch to Core/defineProperties.
emackey 0e85d08
Merge branch 'master' into sunSize
bagnell 16fe2a7
Merge branch 'master' into sunSize
bagnell 83e8840
Fix tests.
bagnell e51b123
Make czm_solarRadius match CesiumMath.SOLAR_RADIUS
emackey 261e79a
Render sun to texture then continue rendering the sun using texture l…
bagnell b98c7df
Update property definition per @mramato's review.
emackey d79c458
Fix build.
emackey 41253b6
Fix sun glow.
bagnell 70f7185
Merge branch 'master' into sunSize
bagnell bc21ad2
Fix after merge.
bagnell 2843349
Remove unused code.
bagnell fb0d752
Tweak the glow to make the inner disc stand out more.
emackey 3402c7e
Fix sun size jumps because of perspective.
bagnell f7e594a
Add property to enable/disable sun bloom filter.
bagnell 33e841c
Updates based on review.
bagnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's cleaner to keep this as a boolean, i.e.,
false
. I suspect we do that elsewhere.