Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add point cloud styling with metadata to ModelExperimental #10569

Merged
merged 6 commits into from
Jul 20, 2022
Merged

Add point cloud styling with metadata to ModelExperimental #10569

merged 6 commits into from
Jul 20, 2022

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Jul 19, 2022

This PR is a followup to #10560 and allows the user to style point clouds while referring to metadata properties in the pnts file.
image

This removes the behavior of adding an empty PropertyTable to point clouds without metadata, which was interfering with styling / debug colorize tiles / statistics. ModelExperimental is now enabled for the 3D Tiles Point Cloud Styling and Montreal Point Cloud sandcastles, as well as some unit tests.

@j9liu j9liu requested a review from ptrgags July 19, 2022 20:08
@cesium-concierge
Copy link

Thanks for the pull request @j9liu!

  • ✔️ Signed CLA found.
  • ❔ CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

ptrgags
ptrgags reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ptrgags ptrgags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j9liu looks good, just had a couple minor comments

Source/Scene/Expression.js Outdated Show resolved Hide resolved
Source/Scene/PointCloud.js Outdated Show resolved Hide resolved
Source/Scene/ModelExperimental/ModelExperimental.js Outdated Show resolved Hide resolved
Source/Scene/ModelExperimental/PointCloudStylingPipelineStage.js Outdated Show resolved Hide resolved
Source/Scene/ModelExperimental/PointCloudStylingPipelineStage.js Outdated Show resolved Hide resolved
@j9liu
Copy link
Contributor Author

j9liu commented Jul 20, 2022

@ptrgags updated

ptrgags
ptrgags reviewed Jul 20, 2022
View reviewed changes
Copy link
Contributor

@ptrgags ptrgags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@j9liu almost there, just a couple last comments

Source/Scene/ModelExperimental/PointCloudStylingPipelineStage.js Outdated Show resolved Hide resolved
Source/Scene/ModelExperimental/ModelExperimental.js Outdated Show resolved Hide resolved
@j9liu
Copy link
Contributor Author

j9liu commented Jul 20, 2022

@ptrgags okay, updated!

@ptrgags
Copy link
Contributor

ptrgags commented Jul 20, 2022

Looks good, thanks @j9liu!

@ptrgags ptrgags merged commit a113a9a into main Jul 20, 2022
@ptrgags ptrgags deleted the metadata-point-cloud-styling branch July 20, 2022 16:38
@ptrgags ptrgags mentioned this pull request Jul 21, 2022
Open
@j9liu j9liu mentioned this pull request Jul 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptrgags ptrgags ptrgags left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@j9liu @cesium-concierge @ptrgags