Cartesian primitive types for issue 1082 #1120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m into issue1082 Conflicts: Source/Core/CorridorGeometry.js
| (!position.equals(pyramid._visualizerPosition) || | ||
| !orientation.equals(pyramid._visualizerOrientation))) { | ||
| (!Cartesian3.equals(position, pyramid._visualizerPosition) || | ||
| !Cartesian3.equals(orientation, pyramid._visualizerOrientation))) { |
There was a problem hiding this comment.
This should be Quaternion.equals.
|
@cmorse I finished looking at your changes in Source. (I haven't looked at the tests yet.) |
|
I'm pretty sure I fixed the culling issue that @mramato found. Is this something worth writing a test for? |
|
I think I got everything. This is ready for another review. |
|
|
||
| Cartesian3.negate(tile.northeastCornerCartesian, cartesian3Scratch); | ||
| Cartesian3.cross(cartesian3Scratch, Cartesian3.UNIT_Z, cartesian3Scratch); | ||
| Cartesian3.normalize(cartesian3Scratch, tile.eastNorma); |
|
This looks good to me. Tests pass. I tested all of the Sandcastle examples and loaded a bunch of CZML files for testing. Thanks @cmorse. Merging. |
bagnell
added a commit
that referenced
this pull request
Sep 20, 2013
Cartesian primitive types for issue 1082
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cartesian primitive types for issue #1082