Fix misleading warnings for OES_standard_derivatives #11308
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Custom Shader fails to compile, the error message begins with an irrelevant warning:
The OES_standard_derivatives extension is only available in WebGL1 contexts. In a WebGL2 context, the derivatives functionality is available by default. However, several of our fragment shaders (written in ES300) still enabled this extension conditionally:
The middle line was then moved to the top of the file in
ShaderSource
without the#ifdef
block, resulting in a warning on WebGL2 contexts.This PR simplifies our handling of the
OES_standard_derivatives
extension. Since it is very commonly used, but only needed in WebGL1, I removed all the code to enable the extension in individual shaders. I then always enable the extension (if available) indemodernizeShader
.The above error message now becomes:
which better emphasizes the relevant error.
The errors can be reproduced with this local Sandcastle