Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terrain & imagery provider ready deprecation fixes #11311

Merged
merged 2 commits into from
May 26, 2023

Conversation

ggetz
Copy link
Contributor

@ggetz ggetz commented May 25, 2023

For testing, here's a local sandcastle with custom terrain and imagery providers. Sandcastles related to terrain or imagery should also be verified.

@cesium-concierge
Copy link

Thanks for the pull request @ggetz!

  • ✔️ Signed CLA found.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@ggetz ggetz marked this pull request as ready for review May 25, 2023 18:07
Copy link
Contributor

@jjhembd jjhembd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ggetz, this looks good overall. I had one question

@jjhembd
Copy link
Contributor

jjhembd commented May 26, 2023

Looks good @ggetz! Merging now

@jjhembd jjhembd merged commit 3906ba3 into main May 26, 2023
@jjhembd jjhembd deleted the terrain-deprecation-fixes branch May 26, 2023 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants