Fix for zoom on tracked entity #11319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @ggetz!
Reviewers, don't forget to make sure that:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11286
In #11268, we tweaked the camera controls when the globe is off.
However, the internals of screenSpaceCameraController override the internal value of
._globewhen a non-identity camera transform is used, such as when tracking an entity. In most cases, this didn't matter. However in non-3D zoom this value did matter, and was now unexpectedly picking a position under the mouse to zoom to, which led to unexpected behavior-- no zooming. I added some additional unit tests to catch this edge case in case it comes up again in the future.