Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for style translucency #11399

Merged
merged 4 commits into from
Jul 6, 2023
Merged

Fix check for style translucency #11399

merged 4 commits into from
Jul 6, 2023

Conversation

j9liu
Copy link
Contributor

@j9liu j9liu commented Jul 6, 2023

Fixes #11300.

This PR corrects the check in Model.applyColorAndShow. The specs didn't catch it because there wasn't a unit test for models without feature tables, so one such unit test was added.

Local sandcastle for testing.

@cesium-concierge
Copy link

Thanks for the pull request @j9liu!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

@j9liu j9liu force-pushed the fix-style-translucency-check branch from 87bd887 to 9f04241 Compare July 6, 2023 15:48
Copy link
Contributor

@ggetz ggetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the fix and the additional unit test @j9liu!

CHANGES.md Outdated Show resolved Hide resolved
@j9liu
Copy link
Contributor Author

j9liu commented Jul 6, 2023

@ggetz just pushed a commit to fix the changelog!

@ggetz
Copy link
Contributor

ggetz commented Jul 6, 2023

Thank you again @j9liu!

@ggetz ggetz merged commit 915f25e into main Jul 6, 2023
@ggetz ggetz deleted the fix-style-translucency-check branch July 6, 2023 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cesium3DTileStyle - alpha value not respected for loaded tiles
3 participants