Return first geometryBuffer if no best batch found #12133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If no exact match by attribute is found in
_findBestGeometryBuffers
return the first one. I believe this was the original intention with this function returning0
for the index.This allows I3S Scenes to render with geometries missing either
["position", "uv0"]
(See issue / sandcastle).Issue number and link
Fixes #12114
Testing plan
https://basemaps3d.arcgis.com/arcgis/rest/services/OpenStreetMap3D_Buildings_v1/SceneServer?layers=ca0470dbbddb4db28bad74ed39949e25
Sandcastle Link
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change