Pin rbush version for use in Commonjs
#12198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @jjspace! ✅ We can confirm we have a CLA on file for you. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
rbushv4updated to only support ES modules but CesiumJS supports ESM and Common JS which means downstream builds using Cesium JS don't work. This pins the version to3.0.1which is the one before4.0Issue number and link
Addresses the error in #12191
Testing plan
npm installto make sure you have the pinned version ofrbushRectangleCollisionCheckerstill works as expected. This is used in clustering, make sure that sandcastle worksAuthor checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change