Geocoder click to trigger search event #12214
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not executed when user clicks a suggestion
|
Thank you for the pull request, @Patsnoop! ✅ We can confirm we have a CLA on file for you. |
jjspace
requested changes
Sep 24, 2024
Comment on lines
+127
to
+128
| //This treats clicking a suggestion the same as hitting the enterKey | ||
| that._searchCommand(); |
There was a problem hiding this comment.
This may technically work but I don't think it's the correct solution. Specifically I'm worried about the circular call of activateSuggestion -> searchCommand -> activateSuggestion. I think a more accurate change would be to alter the click handler on suggestions to behave the same as hitting enter and calling search.
|
@Patsnoop Do you have interest in getting this PR over the finish line? |
|
@ggetz Good Afternoon, I do plan on finishing this up. I will make some time this weekend to work on it and resubmit. |
|
Awesome, thanks @Patsnoop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added a command to make clicking on a suggestion and pressing the enter key react the same
Issue number and link
Fixes #6313 - GeocoderViewModel.search command not executed when user clicks a suggestion - #6313
Testing plan
I ran the program locally and tested the changes on my machine
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change