Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add monish-j to CONTRIBUTORS.md #12332

Closed
wants to merge 2 commits into from
Closed

Add monish-j to CONTRIBUTORS.md #12332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6614b29
Remove deprecated createGooglePhotorealistic3DTileset key option in 1…
monish-j Nov 23, 2024
eaf355e
Add monish-j to CONTRIBUTORS.md
monish-j Nov 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,12 @@
- Updated WMS example URL in UrlTemplateImageryProvider documentation to use an active service. [#12323](https://github.com/CesiumGS/cesium/pull/12323)
- Fix point cloud filtering performance on certain hardware [#12317](https://github.com/CesiumGS/cesium/pull/12317)

##### Deprecated :hourglass_flowing_sand:

- `createGooglePhotorealistic3DTileset(key)` has been deprecated. Use `createGooglePhotorealistic3DTileset({key})` instead. It will be removed in 1.126.

##### Removed :x:

- `createGooglePhotorealistic3DTileset(key)` has been removed. Use `createGooglePhotorealistic3DTileset({key})` instead.


#### @cesium/widgets

Expand Down
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,3 +418,4 @@ See [CONTRIBUTING.md](CONTRIBUTING.md) for details on how to contribute to Cesiu
- [Kirn Kim](https://github.com/squrki)
- [Emanuele Mastaglia](https://github.com/Masty88)
- [Connor Manning](https://github.com/connormanning)
- [Monish Jaiswal](https://github.com/monish-j)
8 changes: 0 additions & 8 deletions packages/engine/Source/Scene/createGooglePhotorealistic3DTileset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import IonResource from "../Core/IonResource.js";
import GoogleMaps from "../Core/GoogleMaps.js";
import Resource from "../Core/Resource.js";
import oneTimeWarning from "../Core/oneTimeWarning.js";
import deprecationWarning from "../Core/deprecationWarning.js";

/**
* Creates a {@link Cesium3DTileset} instance for the Google Photorealistic 3D
Expand Down Expand Up @@ -73,13 +72,6 @@ async function createGooglePhotorealistic3DTileset(apiOptions, tilesetOptions) {
);

apiOptions = defaultValue(apiOptions, defaultValue.EMPTY_OBJECT);
if (typeof apiOptions === "string") {
deprecationWarning(
"createGooglePhotorealistic3DTileset(key)",
"createGooglePhotorealistic3DTileset(key) has been deprecated. It is replaced by createGooglePhotorealistic3DTileset({key}). It will be removed in Cesium 1.126.",
);
apiOptions = { key: apiOptions };
}
if (!apiOptions.onlyUsingWithGoogleGeocoder) {
oneTimeWarning(
"google-tiles-with-google-geocoder",
Expand Down