Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Rectangle.validate #12339

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Remove Rectangle.validate #12339

merged 1 commit into from
Nov 26, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Nov 25, 2024 •
edited
Loading

Description

Issue number and link

Fixes #4921

Testing plan

  • Verify tests still pass
  • This function was essentially a no-op and all internal functions have been replaced with the internal, private, version so there should be no changes for us.

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • I have updated CHANGES.md with a short summary of my change
  • I have added or updated unit tests to ensure consistent code coverage
  • I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

@github-actions GitHub Actions
Copy link

Thank you for the pull request, @jjspace!

✅ We can confirm we have a CLA on file for you.

lukemckinstry
lukemckinstry approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@lukemckinstry lukemckinstry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@lukemckinstry lukemckinstry added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 00d0be4 Nov 26, 2024
10 checks passed
@lukemckinstry lukemckinstry deleted the remove-rectangle-validate branch November 26, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukemckinstry lukemckinstry lukemckinstry approved these changes

Assignees
No one assigned
Labels
priority - next release remove in 1.124
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rectangle.validate is a no-op
2 participants
@jjspace @lukemckinstry