-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Multi source terrain provider #12822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Multi source terrain provider #12822
Conversation
Thank you for the pull request, @juunie-roh! ✅ We can confirm we have a CLA on file for you. |
There is a limitation in the current implementation:
For example:
What causes this is:
This could be solved by nesting HybridTerrainProvider instances, but I'm not sure if it's the right direction. I haven't deeply investigated this limitation yet, as it may be an edge case. |
Thanks for the PR @juunie-roh, and thanks for your patience! Would you mind describing the use case(s) you're looking to address here? It seems like this PR address some, but not all, of the use cases we're looking into for #12817. For instance, I don't believe this handles showing multiple terrain surfaces simultaneously. However, it does appear like this could be useful for many users and would likely still be worth consideration. |
Hi, @ggetz ! 👋 https://juun.vercel.app/cesium-utils/terrain |
Thanks @juunie-roh! Your demonstration looks to be working great. We'll take a closer look at this PR and review shortly. Please let us know if there are any updates to the status of this PR in the meantime. |
Description
This is an initial draft of migration from external library TypeScript implementation into Cesium development environment.
The naming conventions are not considered in this draft.
You can see the detailed description about this feature at the related issue, #12817.
Issue number and link
This PR relates to #12817.
Testing plan
You can see conducted unit tests at external library repository.
Author checklist
CONTRIBUTORS.md
CHANGES.md
with a short summary of my change