-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clamp Billboards and Labels to terrain #2653
Merged
+1,201
−57
Merged
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
19f3ff9
Clamp billboards to ground WIP.
bagnell 45265e3
Hook up callbacks when loading tiles in the quadtree. Billboards on t…
bagnell db403b6
Update quadtree callbacks when billboards are added or removed.
bagnell b7137f5
Move clamp control from billboard collection to billboard.
bagnell ac3aee2
Track clamped position differently from user provided position.
bagnell 5298834
Improve performance by not updating entire quadtree when adding or re…
bagnell 6abe6ed
Fix clamping to billboards to ground in 2D, Columbus view and when mo…
bagnell 83f5dc3
Only use one vertex texture fetch for the depth at the center of the …
bagnell cc013c4
Merge branch 'globe-depth' into billboard-clamp-to-ground
bagnell 9a76c64
Throttle billboards clamped to terrain to only pick the mesh in the g…
bagnell 4583516
Add clamp to ground option to labels.
bagnell 8840623
Clean up picking a terrain tile's mesh and fix billboards when create…
bagnell f115094
Use the frame number when updating callbacks for rendered tiles inste…
bagnell 27df468
Clamp the entire label instead of the individual billboards of the la…
bagnell 8ce9101
Check the last frame rendered and only use callbacks when a tile tran…
bagnell 0acc702
Improve performance. Associate data with the quadtree that will updat…
bagnell fefe944
Change clampToGround boolean to heightReference with enum that can be…
bagnell 1bdde11
Change method for determining billboard visibility.
bagnell e70d140
Add Sandcastle example clamping billboards to the ground.
bagnell 55cc7d3
Add attribute to billboards to compute label visibility.
bagnell 0ae305a
Only update billboard position on terrain loaded.
bagnell b25eac7
Remove updating the billboard on tile load. Update the position on ti…
bagnell 8d3377c
Fix updating height reference and changine position. Fixed columbus v…
bagnell ae61e7a
Update Sandcastle example.
bagnell b941902
Some updates base don review.
bagnell 6fefe5b
Merge branch 'globe-depth' into billboard-clamp-to-ground
bagnell 2b5ae80
Rename maxSize to ownerSize. Update labels and other changes based on…
bagnell 220f3b2
More renames and updates based on review.
bagnell 2ff3d43
Add doc.
bagnell 6c722f9
Update computing screen space position for billboards and labels.
bagnell 9b1f561
Move time slicing code from the billboard/label collection to the qua…
bagnell 0b2a63a
Stop updating billboards/labels when the height for the lowest level …
bagnell 26d6ad5
Fix updating billboard/label height reference and position.
bagnell d9061fb
Rename from review.
bagnell fb7901e
Update Sandcastle example.
bagnell 344619d
Update doc.
bagnell f68c78b
Improve update performance.
bagnell 1770da4
Update labels/billboards when the terrain provider changes.
bagnell 9f7f1ab
Fix ciolumbus view. Clean up requires.
bagnell 58980dc
Re-add eye z offset.
bagnell 3b7c13b
Add tests for billboards/labels with height references and for the qu…
bagnell 83fd26d
Merge branch 'globe-depth' into billboard-clamp-to-ground
bagnell 9fff44c
Update CHANGES.md
bagnell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update Sandcastle example.
- workspaces
- pre-template-literals
- pre-prettier-v3
- pre-prettier
- pre-let-const
- post-workspaces
- post-template-literals
- post-prettier-v3
- post-prettier
- post-let-const
- cesium-workspaces
- 1.127
- 1.126
- 1.125
- 1.124
- 1.123.1
- 1.123
- 1.122
- 1.121.1
- 1.121
- 1.120
- 1.119
- 1.118.2
- 1.118.1
- 1.118
- 1.117
- 1.116
- 1.115
- 1.114
- 1.113
- 1.112
- 1.111
- 1.111-release
- 1.110.1
- 1.110
- 1.109
- 1.108
- 1.107.2
- 1.107.1
- 1.107
- 1.106.1
- 1.106
- 1.105.2
- 1.105.1
- 1.105
- 1.104
- 1.103
- 1.102
- 1.101
- 1.100
- 1.99
- 1.98.1
- 1.98
- 1.97
- 1.96
- 1.95
- 1.94.3
- 1.94.2
- 1.94.1
- 1.94
- 1.93
- 1.92
- 1.91
- 1.90
- 1.89
- 1.88
- 1.87.1
- 1.87
- 1.86.1
- 1.86
- 1.85
- 1.84
- 1.83
- 1.82
- 1.81
- 1.80
- 1.79.1
- 1.79
- 1.78
- 1.77
- 1.76
- 1.75
- 1.74
- 1.73
- 1.72
- 1.71
- 1.70.1
- 1.70
- 1.69
- 1.68
- 1.67
- 1.66
- 1.65
- 1.64
- 1.63.1
- 1.63
- 1.62
- 1.61
- 1.60
- 1.59
- 1.58.1
- 1.58
- 1.57
- 1.56.1
- 1.56
- 1.55
- 1.54
- 1.53
- 1.52
- 1.51
- 1.50
- 1.49
- 1.48
- 1.47
- 1.46
- 1.45
- 1.44
- 1.43
- 1.42.1
- 1.42
- 1.41
- 1.40
- 1.39
- 1.38
- 1.37
- 1.36
- 1.35.2
- 1.35
- 1.34
- 1.33
- 1.32
- 1.31
- 1.30
- 1.29
- 1.28
- 1.27
- 1.26
- 1.25
- 1.24
- 1.23
- 1.22.2
- 1.22.1
- 1.22
- 1.21
- 1.20
- 1.19
- 1.18
- 1.17
- 1.16
- 1.15
- 1.14
- 1.13
- 1.12
- 1.11
- 1.10
commit ae61e7abacf9077068c44dbd60e9c614bceec4ba
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still wouldn't pass globe here, no need for the user to reach that need. Just
scene
is fine, but still not ideal.