Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issue #405 #2949

Merged
merged 2 commits into from
Aug 18, 2015
Merged

Resolve issue #405 #2949

merged 2 commits into from
Aug 18, 2015

Conversation

slozier
Copy link
Contributor

@slozier slozier commented Aug 18, 2015

Fixes integer arithmetic issue.

For any integer x >= 0, the following ranges of dates were not parsed properly:
(400_x+43)-03-01 to (400_x+100)-02-28 and (400_x+167)-03-01 to (400_x+200)-02-28

@pjcozzi
Copy link
Contributor

pjcozzi commented Aug 18, 2015

Awesome, thanks @slozier! Can you update CHANGES.md?

@mramato I imagine you want to review?

@mramato
Copy link
Contributor

mramato commented Aug 18, 2015

Awesome! This bug has annoyed me forever and I always assumed it was some stupid simple error like this but could never track it down. Thanks a lot.

Can you merge in master to fix the CHANGES conflict? As soon as you do I'll merge this up. Thanks again.

@slozier
Copy link
Contributor Author

slozier commented Aug 18, 2015

@mramato I think it should be good to go.

@mramato
Copy link
Contributor

mramato commented Aug 18, 2015

Thanks again.

mramato added a commit that referenced this pull request Aug 18, 2015
@mramato mramato merged commit a01df10 into CesiumGS:master Aug 18, 2015
@slozier slozier deleted the issue_405 branch August 18, 2015 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants