Fix disappearing terrain #3365
Merged
Fix disappearing terrain #3365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still happens on my machine. Stop by and I'll show you. |
…to be added to the render list.
|
I can confirm that this fixes both issues. Does anyone else want to review this? |
|
@bagnell is this the final implementation |
|
Did you get to the root of the issue as we discussed offline? |
| @@ -540,41 +540,54 @@ define([ | |||
| */ | |||
| GlobeSurfaceTileProvider.prototype.computeDistanceToTile = function(tile, frameState) { | |||
There was a problem hiding this comment.
@lilleyse we want this fix in the 3d-tiles branch TileBoundingBox class, otherwise we will reintroduce this bug when merging TileBoundingBox to master. You might want to cherry pick these commits and make the change right away.
|
Looks good! |
lilleyse
added a commit
that referenced
this pull request
Dec 22, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue of disappearing terrain when fog is active (#3335). Changes
GlobeSurfaceTileProvider.computeDistanceToTileto return0.0when the camera is inside the tile bounding region.