Added regex pattern to color map #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (defined(this._pattern)) { | ||
| var match = this._pattern.exec(value); | ||
| if (defined(match)) { | ||
| value = match[1]; |
There was a problem hiding this comment.
Make a new local variable instead of assigning to value again (it will also default to undefined).
|
Just that comment, this looks good, @ggetz. Please check items off the roadmap, CesiumGS/3d-tiles#2, as you finish them. |
|
Fixed and marked off on the roadmap. |
|
Looks good! |
pjcozzi
added a commit
that referenced
this pull request
Feb 12, 2016
Added regex pattern to color map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to specify a regex to the color map and added the option to the sandcastle example for color map.