-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite horizontal scrolling in 2D #3621
Conversation
…rmally when it is not.
…edits once a frame.
…points when the camera is offscreen WIP.
…e viewport in 2D.
Merge in master. |
The right click zoom out starts to translate strangely at max zoom out. Can we clamp it? |
What happens if the viewer sets the camera height above the new max in 2D? |
In 2D, use the geocoder to fly to |
For #3621 (comment), it might be easier to reproduce it in the GeoJSON Sandcastle example: |
For #3621 (comment), check out the Geoeye orbit in the CZML Sandcastle example. The line left of the IDL (or in the left viewport?) jitters. Also go fullscreen, and you'll see several vertical black line artifacts on the left side. |
For #3621 (comment), it also happens in master after clicking the cardboard button. Its most likely an issue with converting to window coordinates in the shader when there are multiple viewports. I'll open a PR into master when its fixed. |
@pjcozzi This is ready for another review. |
Also if you mouse over above or below in the Picking Sandcastle example, the label moves to the wrong place. |
Just those comments. |
No, i haven't seen that. The IDL should only visible at most in one location. How did you zoom out that far? Your AGI billboard comment is the same issue. |
Yes, I'm not sure how to fix that without computing the corner points of the billboard, projecting them to 2D and splitting them across the IDL each frame. |
Tested on Mac. All looks good! |
Adds infinite scrolling in 2D.