Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite horizontal scrolling in 2D #3621

Merged
merged 62 commits into from
Mar 24, 2016
Merged

Infinite horizontal scrolling in 2D #3621

merged 62 commits into from
Mar 24, 2016

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Feb 23, 2016

Adds infinite scrolling in 2D.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 23, 2016

Merge in master.

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 23, 2016

The right click zoom out starts to translate strangely at max zoom out. Can we clamp it?

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 23, 2016

What happens if the viewer sets the camera height above the new max in 2D?

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 23, 2016

In 2D, use the geocoder to fly to -180, 0. It flies to the wrong location and crashes here and in master.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

Do you get this artifact in 2D when zooming in and out in the G&A example? It is not in master.

ok

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

Testing with the GeoJSON Sandcastle example, the selection indicator turns off early when scrolling to the right:
ok

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

For #3621 (comment), it might be easier to reproduce it in the GeoJSON Sandcastle example:

ok

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 21, 2016

For #3621 (comment), check out the Geoeye orbit in the CZML Sandcastle example. The line left of the IDL (or in the left viewport?) jitters.

ok

Also go fullscreen, and you'll see several vertical black line artifacts on the left side.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 22, 2016

For #3621 (comment), it also happens in master after clicking the cardboard button. Its most likely an issue with converting to window coordinates in the shader when there are multiple viewports. I'll open a PR into master when its fixed.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 23, 2016

@pjcozzi This is ready for another review.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 23, 2016

Do you get the black flicker on the edge of the viewport when panning in the CZML Sandcastle example:

ok

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 23, 2016

Only one AGI billboard is highlighted here. Is this just the way it is for now?

image

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 24, 2016

What do you suggest for labels (and billboards I imagine) crossing the IDL/viewport? Write up an issue with known 2D issues?

Using the Sandcastle Picking example:

ok

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 24, 2016

Also if you mouse over above or below in the Picking Sandcastle example, the label moves to the wrong place.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 24, 2016

Just those comments.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 24, 2016

Do you get the black flicker on the edge of the viewport when panning in the CZML Sandcastle example?

No, i haven't seen that. The IDL should only visible at most in one location. How did you zoom out that far? Your AGI billboard comment is the same issue.

@bagnell
Copy link
Contributor Author

bagnell commented Mar 24, 2016

What do you suggest for labels (and billboards I imagine) crossing the IDL/viewport? Write up an issue with known 2D issues?

Yes, I'm not sure how to fix that without computing the corner points of the billboard, projecting them to 2D and splitting them across the IDL each frame.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 24, 2016

Tested on Mac.

All looks good!

@pjcozzi pjcozzi merged commit b937a5c into master Mar 24, 2016
@pjcozzi pjcozzi deleted the infinite-2D-only branch March 24, 2016 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants