Rotate back across the globe when points cross the IDL #4507
Conversation
|
Corrected output:
|
|
I don't think that's quite right @lasalvavida. One of the blue rectangles should be rotated. The result should look like the yellow rectangles. |
|
Can you add a unit test for this? |
|
As discussed offline, this is the expected output: var western2 = createWesternRectangle(0.005);The blue rectangle is only rotated a small amount. |
|
Adding a test now. Just to be clear, the crux of this issue is that the rectangle has its northwest corner on the opposite of the IDL from its center. So, when we do the following: nwCartesian = Cartesian3.subtract(nwCartesian, centerCartesian, nwCartesian);Instead of getting the very small difference between them, we subtract a negative value, producing a large offset which blows up small rotations to the point where it causes a translation. |
| @@ -118,6 +118,10 @@ define([ | |||
| granYSin = granularityY * sinRotation; | |||
| granXSin = granularityX * sinRotation; | |||
|
|
|||
| if (center.longitude < nwCorner.longitude) { | |||
| center.longitude += 2 * Math.PI; | |||
|
Looks good to me @lasalvavida! I just had that one comment. |
|
Test added! |
|
Great, thanks @lasalvavida! |
|
@hpinkos please update CHANGES.md in master. |
Fix for #3874.