Fix RectangleGeometry texture rotation #4725
Merged
+176
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 7, 2016
|
@hpinkos One thing I checked (and want to stress) is that this bug was more/most obvious when the aspect ratio of the rect was bigger (i.e more rectangular, less square.) I did that test and it looks great. Thanks! |
|
Amazing! @hpinkos please update all the issues and/or forum posts about this, thanks! |
|
Thank you!! This was extremely helpful. It works great when I point to master. Will this be part of release 1.29 at the very beginning of January? |
|
@jburr-nc yep! This will be included in 1.29 released on January 2 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2737
Before the texture was being rotated using a texture rotation matrix. This wasn't working because the
RectangleGeometryis rotated in Cartographic space (so it remains a rectangle in 2D) and using the matrix to rotate the texture coordinates made them no longer line up with the positions.To fix this, I compute the rotated texture coordinates based on the angle difference between the texture coordinate rotation and the rectangle rotation.