Fixed a crash when using Entity path visualization with references #4917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perties. Fixes #4915 There were several bugs here: 1. `PathVisualizer` was unwrapping a `ReferenceProperty`, finding a `CompositePositionProperty` inside, and then using the reference as if it was a composite instead of using the inner property. 2. Same was 1, but for `TimeIntervalCollectionPositionProperty` 3. We were unwrapping `ScaledPositionProperty` and using the inner property directly, but this prevented the value from actually being scaled properly. Now we use the `ScaledPositionProperty` which means it falls back to a generic sampling path but that's the best solution. (Not to mention that ScaledPositionProperty is privat and will eventually go away).
emackey
approved these changes
Jan 25, 2017
Care to elaborate on this? |
|
Yes. There will be a new issue forthcoming, when I can get a public test case. But basically, when the ellipsoid is present on an inclined GEO spacecraft orbit, the selectionIndicator appears on a point that seems to have about half of the spacecraft's latitude. Strange. EDIT: This is now explained in issue #4929. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4915
There were several bugs here:
PathVisualizerwas unwrapping aReferenceProperty, finding aCompositePositionPropertyinside, and then using the reference as if it was a composite instead of using the inner property.TimeIntervalCollectionPositionPropertyScaledPositionPropertyand using the inner property directly, but this prevented the value from actually being scaled properly. Now we use theScaledPositionPropertywhich means it falls back to a generic sampling path but that's the best solution. (Not to mention that ScaledPositionProperty is private and will eventually go away).