3D Tiles - Memory statistics for models and tiles #5050

lilleyse · 2017-02-28T22:42:23Z

This PR adds support for getting the size in bytes of a texture, model, tile, and adds statistics for these to the inspector.

To-do:

Does not report memory correctly for i3dm tilesets since tiles share resources.

pjcozzi · 2017-03-08T00:18:58Z

Does not report memory correctly for i3dm tilesets since tiles share resources.

Two options

Do this as part of this PR
Add it to the roadmap for now and add a warning in the inspector report that i3dm tiles are not yet counted

I suggest the first unless there is something major stopping it.

pjcozzi · 2017-03-08T00:20:47Z

Source/Core/PixelFormat.js

@@ -144,6 +146,28 @@ define([
        /**
         * @private
         */
+        componentLength : function(pixelFormat) {


Perhaps componentSizeInBytes? "Length" sounds like, for example, RGB would be three: R, G, and B.

This actually is for that case where RGB is three.

PixelDatatype figures out the sizeInBytes for each component, and the two numbers are multiplied for a final size.

numberOfComponents? Or componentsLength (note the "s")?

pjcozzi · 2017-03-08T00:21:35Z

Source/Core/PixelFormat.js

+        /**
+         * @private
+         */
+        textureSize : function(pixelFormat, pixelDatatype, width, height) {


Same comment throughout.

pjcozzi · 2017-03-08T00:21:58Z

Feel free to cherry pick some changes, like those in PixelFormat.js, into a PR into master.

pjcozzi · 2017-03-08T00:25:07Z

Source/Renderer/CubeMap.js

@@ -313,6 +321,9 @@ define([
        gl.bindTexture(target, this._texture);
        gl.generateMipmap(target);
        gl.bindTexture(target, null);
+
+        // The mipmap adds approximately 1/3 of the original texture size
+        this._sizeInBytes = Math.floor(this._sizeInBytes * 4 / 3);


A user could call generateMipmap more than once. Either save the original size and recompute here, or just compute every time in the get function based on if this is mipmapped.

pjcozzi · 2017-03-08T00:26:08Z

Source/Renderer/PixelDatatype.js

+            switch (pixelDatatype) {
+                case PixelDatatype.UNSIGNED_BYTE:
+                    return 1;
+                case PixelDatatype.UNSIGNED_SHORT:


I like this fall-through case style as well; I was going to suggest to use it in the PixelFormat.js changes. Perhaps it's a good idea.

pjcozzi · 2017-03-08T00:26:32Z

Source/Renderer/Texture.js

@@ -561,6 +575,9 @@ define([
        gl.bindTexture(target, this._texture);
        gl.generateMipmap(target);
        gl.bindTexture(target, null);
+
+        // The mipmap adds approximately 1/3 of the original texture size
+        this._sizeInBytes = Math.floor(this._sizeInBytes * 4 / 3);


Same comment.

pjcozzi · 2017-03-08T00:28:29Z

Source/Scene/Cesium3DTileBatchTable.js

@@ -132,6 +134,21 @@ define([
        this._textureStep = textureStep;
    }

+    defineProperties(Cesium3DTileBatchTable.prototype, {
+        textureMemoryInBytes : {


Ah, I did not think about batch table vs. texture memory. Perhaps it is better to report these separately so it is less confusing to the end users that might not realize that the batch table is stored in a texture.

pjcozzi · 2017-03-08T00:29:35Z

Source/Scene/Empty3DTileContent.js

+        /**
+         * Part of the {@link Cesium3DTileContent} interface.
+         */
+        vertexMemoryInBytes : {


Throughout "MemoryInBytes" should probably be "SizeInBytes."

pjcozzi · 2017-03-08T00:31:13Z

Source/Scene/Model.js

+         *
+         * @private
+         */
+        vertexMemoryInBytes : {


When a model is cached, 3D Tiles should only report the memory for one model even if, for example, two b3dm tiles reference it.

pjcozzi · 2017-03-08T00:32:04Z

Source/Scene/Model.js

+            get : function() {
+                var memory = 0;
+                var buffers = this._rendererResources.buffers;
+                for (var id in buffers) {


Here and below seem like something we should cache in a property.

pjcozzi · 2017-03-08T00:32:38Z

Looks great!

lilleyse · 2017-03-09T22:05:36Z

Source/Scene/Batched3DModel3DTileContent.js

@@ -316,7 +354,7 @@ define([
            gltf : gltfView,
            cull : false,           // The model is already culled by the 3D tiles
            releaseGltfJson : true, // Models are unique and will not benefit from caching so save memory
-            basePath : getBaseUri(this._url, true),
+            basePath : getAbsoluteUri(getBaseUri(this._url, true)),


This change here was added because tiles pointing to the same resources might have different paths due to ../../ and other path separators. In effect this normalizes the uri.

lilleyse · 2017-03-09T22:10:39Z

Updated now. I have a TODO left in the code for when #5051 is merged. The memory tracking in Model was written with that in mind, so it should be easy to handle a global texture cache.

pjcozzi · 2017-03-10T01:32:03Z

Updated now. I have a TODO left in the code for when #5051 is merged...

OK, will look at that as soon as I can.

lilleyse added 4 commits February 28, 2017 17:40

Get memory statistics for models and tiles

23968fd

Merge branch '3d-tiles' into memory-statistics

85ce618

Fix calculation

9b0438f

Add memory getters to Composite3DTileContent

163c99a

lilleyse mentioned this pull request Mar 6, 2017

Textured i3dm and external resources tileset CesiumGS/3d-tiles-validator#61

Merged

Added compressed texture tilesets

c5f53f7

pjcozzi reviewed Mar 8, 2017

View reviewed changes

Merge branch '3d-tiles' into memory-statistics

17bd2fb

lilleyse force-pushed the memory-statistics branch 2 times, most recently from a3dcc24 to fa8d5b4 Compare March 9, 2017 21:47

Renaming, dealing with model cache, separating batch table memory

b9eee23

lilleyse force-pushed the memory-statistics branch from fa8d5b4 to b9eee23 Compare March 9, 2017 22:00

lilleyse commented Mar 9, 2017

View reviewed changes

Small fixes

db9bfac

pjcozzi merged commit 0a2aceb into 3d-tiles Mar 10, 2017

pjcozzi deleted the memory-statistics branch March 10, 2017 01:40

lilleyse mentioned this pull request Apr 3, 2017

Show triangle count in 3D Tiles inspector #5174

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

3D Tiles - Memory statistics for models and tiles #5050

3D Tiles - Memory statistics for models and tiles #5050

lilleyse commented Feb 28, 2017 •

edited

Loading

pjcozzi commented Mar 8, 2017

pjcozzi Mar 8, 2017

lilleyse Mar 9, 2017

pjcozzi Mar 10, 2017

pjcozzi Mar 8, 2017

pjcozzi commented Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi Mar 8, 2017

pjcozzi commented Mar 8, 2017

lilleyse Mar 9, 2017

lilleyse commented Mar 9, 2017 •

edited

Loading

pjcozzi commented Mar 10, 2017

3D Tiles - Memory statistics for models and tiles #5050

3D Tiles - Memory statistics for models and tiles #5050

Conversation

lilleyse commented Feb 28, 2017 • edited Loading

pjcozzi commented Mar 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Mar 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjcozzi commented Mar 8, 2017

Choose a reason for hiding this comment

lilleyse commented Mar 9, 2017 • edited Loading

pjcozzi commented Mar 10, 2017

lilleyse commented Feb 28, 2017 •

edited

Loading

lilleyse commented Mar 9, 2017 •

edited

Loading