Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to pick entities from cluster #5409

Merged
merged 2 commits into from
Jun 2, 2017

Conversation

moneimne
Copy link
Contributor

@moneimne moneimne commented Jun 1, 2017

Fix for #5286

@hpinkos
Copy link
Contributor

hpinkos commented Jun 1, 2017

@bagnell is this what you had in mind? This sets the id property of the cluster primitive to the array of entity ids. Then in the Sandcastle example, it changes the color of the billboards that were in the cluster you clicked on.

@bagnell
Copy link
Contributor

bagnell commented Jun 1, 2017

Yes, thanks @moneimne!

@bagnell
Copy link
Contributor

bagnell commented Jun 1, 2017

Can you update CHANGES.md and update any forum threads linked in the issue that this is fixed and will be in the next release?

@hpinkos
Copy link
Contributor

hpinkos commented Jun 2, 2017

@moneimne is this ready? Make sure you add a comment whenever a pull request is ready for another look so the review gets notified

@moneimne
Copy link
Contributor Author

moneimne commented Jun 2, 2017

Yes, this is ready. I haven't updated the forum thread, though. Should I do that?

@hpinkos
Copy link
Contributor

hpinkos commented Jun 2, 2017

This looks great @moneimne, thanks! When users report bugs on the forum, we like to give them an update when the bug is fixed. So now that this is merged you can reply to the forum post linked in #5286

@hpinkos hpinkos merged commit 1130146 into CesiumGS:master Jun 2, 2017
@hpinkos
Copy link
Contributor

hpinkos commented Jun 2, 2017

Side note: In your initial comment, say 'Fixes #5286' instead of 'Fix for #5286' so github will automatically close the linked issue when a pull request is merged

@moneimne
Copy link
Contributor Author

moneimne commented Jun 2, 2017

Done! Thanks for all the help, @hpinkos!

@moneimne moneimne deleted the pickingInClusteringSandcastle branch June 2, 2017 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants