Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gltf-pipeline #5867

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Update gltf-pipeline #5867

merged 1 commit into from
Oct 2, 2017

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Oct 2, 2017

Fixes #5856

This makes cesium and gltf-pipeline fully in-sync.

Notes on some of these changes are here: CesiumGS/gltf-pipeline#324

@cesium-concierge
Copy link

@lilleyse, thanks for the pull request! Maintainers, we have a signed CLA from @lilleyse, so you can review this at any time.

I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.

I noticed that a file in one of our ThirdParty folders (ThirdParty/, Source/ThirdParty/) has been added or modified. Please verify that it has a section in LICENSE.md and that its license information is up to date with this new version. Once you do, please confirm by commenting on this pull request.

I am a bot who helps you make Cesium awesome! Thanks again.

@mramato
Copy link
Contributor

mramato commented Oct 2, 2017

In the future, can we include the git hash of the pipeline version in the commit message so that we know exactly where it came from?

@mramato
Copy link
Contributor

mramato commented Oct 2, 2017

Everything appears to be working fine. Thanks @lilleyse!

@mramato mramato merged commit 7cfbf34 into master Oct 2, 2017
@mramato mramato deleted the update-gltf-pipeline branch October 2, 2017 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants