Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gulpfile from release #6025

Closed
wants to merge 1 commit into from
Closed

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Dec 1, 2017

Fixes #3911

The release zips are only meant for using Cesium, not building it, so there's no need to include the gulpfile.

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 15, 2017

Anyone else want to look at this before we merge?

@mramato
Copy link
Contributor

mramato commented Dec 15, 2017

I'm not sure this really fixes the issue because there will still be gulp-based tasks listed in package.json, so it's not going to stop our users from attempting to run build tasks against the release zip and submitting github issues or forum posts because they think it's broken. We could modify the package.json during zip creation so that it only include support commands.

But the real question we need to answer is, "What else are do we support doing with the release zip?":

  1. Should you be able to rebuild Cesium (and Apps and documentation)?
  2. Should you be able to run all tests?
  3. Should you be able to run jsHint/eslint and other build stuff?

Depending on the answers to these questions (and maybe others I glanced over) we can modify the zip further to better suit the needs.

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 15, 2017

  1. yes

  2. and 3. sure, if it is easy enough.

No rush on this, just curating some PRs for 1.41.

@hpinkos
Copy link
Contributor Author

hpinkos commented Jan 2, 2018

Closing this since it doesn't seem like the solution we want. Continue discussion in #3911

@hpinkos hpinkos deleted the remove-gulpfile-from-release branch January 16, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants