Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build module url #6231

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Fixed build module url #6231

merged 2 commits into from
Feb 19, 2018

Conversation

tfili
Copy link
Contributor

@tfili tfili commented Feb 18, 2018

Fixes #6225

With the introduction of the Resource class we accidentally required a trailing slash to CESIUM_BASE_URL.

@tfili tfili requested a review from hpinkos February 18, 2018 01:38
@cesium-concierge
Copy link

Signed CLA is on file.

@tfili, thanks for the pull request! Maintainers, we have a signed CLA from @tfili, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@tfili tfili force-pushed the fixed-build-module-url branch from 213d3de to 08b4153 Compare February 18, 2018 01:46
@mramato
Copy link
Contributor

mramato commented Feb 19, 2018

Looks good, update CHANGES and I'll merge.

@tfili
Copy link
Contributor Author

tfili commented Feb 19, 2018

@mramato Updated CHANGES.

@mramato mramato merged commit 9bf3feb into master Feb 19, 2018
@mramato mramato deleted the fixed-build-module-url branch February 19, 2018 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants