Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo when cloning ShaderSource. #6234

Merged
merged 1 commit into from
Feb 21, 2018
Merged

Fix typo when cloning ShaderSource. #6234

merged 1 commit into from
Feb 21, 2018

Conversation

bagnell
Copy link
Contributor

@bagnell bagnell commented Feb 19, 2018

This might fix any bugs with picking translucent geometry. I quickly looked at existing issues but didn't find anything.

@cesium-concierge
Copy link

Signed CLA is on file.

@bagnell, thanks for the pull request! Maintainers, we have a signed CLA from @bagnell, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato
Copy link
Contributor

mramato commented Feb 19, 2018

I think someone on the forum recently had translucent picking issues @hpinkos or @ggetz may know for sure.

@ggetz
Copy link
Contributor

ggetz commented Feb 19, 2018

@mramato
Copy link
Contributor

mramato commented Feb 19, 2018

Possibly, I just remember hearing something about a translucent picking bug recently.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 21, 2018

Good catch @bagnell!

@hpinkos hpinkos merged commit 16fd74e into master Feb 21, 2018
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!searchin/cesium-dev/pick%7Csort

If this issue affects any of these threads, please post a comment like the following:

The issue at #6234 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos hpinkos deleted the fix-typo branch February 21, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants