Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic geometry updater inheritance #6253

Merged
merged 4 commits into from
Feb 22, 2018
Merged

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Feb 22, 2018

Use inheritance for DynamicGeometryUpdater classes to reduce duplicate code
I think this will be the last of my DataSource refactor/cleanup pull requests.

TODO

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@mramato mramato changed the base branch from geometry-updater-inheritence to master February 22, 2018 18:58
@mramato
Copy link
Contributor

mramato commented Feb 22, 2018

Please merge in master.

@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 22, 2018

@mramato ready

@mramato
Copy link
Contributor

mramato commented Feb 22, 2018

This example looks broken: http://localhost:8080/Apps/Sandcastle/index.html?src=Rectangle.html&label=Geometries I actually think it was one of your previous PRs that broke it (master is broken too but worked 7 commits ago). Might as well fix it now.

@@ -228,7 +224,13 @@ define([
this._material = {};
}

DynamicGeometryUpdater.prototype.update = function(time) {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whitespace

@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 22, 2018

@mramato just fixed the rectangle issue. And thanks to inheritance I just had to fix it in one place instead of like 10 😃

@hpinkos hpinkos force-pushed the dynamic-updater-inheritance branch from 05bd0aa to 16b1876 Compare February 22, 2018 22:04
@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 22, 2018

This should be ready now

@mramato
Copy link
Contributor

mramato commented Feb 22, 2018

Thanks!

@mramato mramato merged commit aff417b into master Feb 22, 2018
@mramato mramato deleted the dynamic-updater-inheritance branch February 22, 2018 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants