-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic geometry updater inheritance #6253
Conversation
@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
Please merge in master. |
@mramato ready |
This example looks broken: http://localhost:8080/Apps/Sandcastle/index.html?src=Rectangle.html&label=Geometries I actually think it was one of your previous PRs that broke it (master is broken too but worked 7 commits ago). Might as well fix it now. |
@@ -228,7 +224,13 @@ define([ | |||
this._material = {}; | |||
} | |||
|
|||
DynamicGeometryUpdater.prototype.update = function(time) { | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespace
@mramato just fixed the rectangle issue. And thanks to inheritance I just had to fix it in one place instead of like 10 😃 |
05bd0aa
to
16b1876
Compare
This should be ready now |
Thanks! |
Use inheritance for
DynamicGeometryUpdater
classes to reduce duplicate codeI think this will be the last of my DataSource refactor/cleanup pull requests.
TODO