Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeometryVisualizer subscribe once per entity, not once per geometry #6263

Merged
merged 4 commits into from
Feb 23, 2018

Conversation

hpinkos
Copy link
Contributor

@hpinkos hpinkos commented Feb 22, 2018

Leftover from #6239

Instead of listening to entity.definitionChanged once per geometry type, this listens to entity.definitionChanged once and loops through each geometry type when it is trigggered.

@cesium-concierge
Copy link

Signed CLA is on file.

@hpinkos, thanks for the pull request! Maintainers, we have a signed CLA from @hpinkos, so you can review this at any time.

⚠️ I noticed that CHANGES.md has not been updated. If this change updates the public API in any way, fixes a bug, or makes any non-trivial update, please add a bullet point to CHANGES.md and comment on this pull request so we know it was updated. For more info, see the Pull Request Guidelines.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

@hpinkos hpinkos requested a review from mramato February 22, 2018 21:43
@mramato
Copy link
Contributor

mramato commented Feb 23, 2018

Looks like you have some failing tests.

@hpinkos
Copy link
Contributor Author

hpinkos commented Feb 23, 2018

@mramato ready

@mramato
Copy link
Contributor

mramato commented Feb 23, 2018

Thanks, not sure how much of a perceivable impact it will have, but this will significantly reduce the number of entity subscriptions by 10x, and that should lead to less memory usage and way less iteration when something changes..

@mramato mramato merged commit 006c8c0 into master Feb 23, 2018
@mramato mramato deleted the updater-subscriptions branch February 23, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants