Auto-generate a label of new demos since last minor version. #6389
Conversation
If a new demo has been added since the latest minor version (i.e. 1.43.x will include everything from 1.42.x as new) add it to a `New in 1.x` label. Make this label always be second in the list after Showcases.
|
@mramato, thanks for the pull request! Maintainers, we have a signed CLA from @mramato, so you can review this at any time.
I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome. 🌍 🌎 🌏 |
On travis, the version is set something like '1.43.0-branch-name-travisBuildNumber'. We only need the major.minor version and we need to decrement it to get the previous release.
gulpfile.js
Outdated
|
|
||
| // Get an array of demos that were added since the last release. | ||
| // This includes newly staged local demos as well. | ||
| var newDemos = child_process.execSync('git diff --name-only --diff-filter=A ' + tagVersion + ' Apps/Sandcastle/gallery/*.html').toString().trim().split('\n'); |
There was a problem hiding this comment.
Does anyone ever need to build Cesium outside of the git repo, like from a zip file? What happens if this fails?
There was a problem hiding this comment.
This will throw if it fails (failing the build). While the answer has always been nebulous, we don't really support building out of the zip file. However, since it was trivial I changed it to catch the error and print out a warning instead of failing. Should be good to go.
|
This is pretty cool. 👍 Just the one comment, I think we should be fault-tolerant when attempting to run git commands without knowing if we're in the repo or if git is even installed. |
Cesium is not defined in the built version of Sandcastle.
|
Very cool, thanks! |
If a new demo has been added since the latest minor version (i.e. 1.43.x will include everything from 1.42.x as new) add it to a
New in 1.xlabel. Make this label always be second in the list after Showcases.Also got rid of generated
dateproperty, since it wasn't used.Fixes #6384